Skip to content

Support InetSocket in the tracker#2671

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:wrap-tcp-rust
Jan 19, 2023
Merged

Support InetSocket in the tracker#2671
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:wrap-tcp-rust

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Jan 18, 2023 •
edited
Loading

This adds support for InetSocket in the tracker, and reverts the change from #2626.

@stevenengler stevenengler self-assigned this Jan 18, 2023
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Jan 18, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 18, 2023 •
edited
Loading

Codecov Report

Base: 67.78% // Head: 67.58% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (30f83f4) compared to base (1056fef).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2671      +/-   ##
==========================================
- Coverage   67.78%   67.58%   -0.20%     
==========================================
  Files         202      202              
  Lines       30319    30326       +7     
  Branches     5923     5923              
==========================================
- Hits        20552    20497      -55     
- Misses       5095     5169      +74     
+ Partials     4672     4660      -12
Flag Coverage Δ
tests 67.58% <50.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/descriptor/socket/inet/mod.rs 28.12% <20.00%> (-0.91%) ⬇️
src/main/host/descriptor/socket/inet/tcp.rs 67.02% <100.00%> (+0.54%) ⬆️
src/main/host/syscall/handler/eventfd.rs 0.00% <0.00%> (-25.00%) ⬇️
src/main/host/descriptor/eventfd.rs 0.00% <0.00%> (-21.22%) ⬇️
src/main/host/syscall/handler/ioctl.rs 40.00% <0.00%> (-17.15%) ⬇️
src/main/host/memory_manager/memory_mapper.rs 68.73% <0.00%> (-2.90%) ⬇️
src/main/core/logger/shadow_logger.rs 69.61% <0.00%> (-2.77%) ⬇️
src/main/network/graph/mod.rs 56.52% <0.00%> (-1.68%) ⬇️
src/main/host/host.rs 79.96% <0.00%> (-0.72%) ⬇️
src/main/host/descriptor/pipe.rs 84.37% <0.00%> (-0.63%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stevenengler stevenengler force-pushed the wrap-tcp-rust branch 2 times, most recently from fc18230 to aea735e Compare January 18, 2023 19:26
@stevenengler stevenengler changed the title InetSocket: support in the tracker, and use in the network interface Support InetSocket in the tracker Jan 19, 2023
@stevenengler stevenengler marked this pull request as ready for review January 19, 2023 18:07
sporksmith
sporksmith approved these changes Jan 19, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sporksmith sporksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible. It might be nice to have some tracker tests, but no need to block this on it.

@stevenengler
Copy link
Copy Markdown
Contributor Author

stevenengler commented Jan 19, 2023 •
edited
Loading

Looks plausible. It might be nice to have some tracker tests, but no need to block this on it.

Yeah I agree, but I did just run a tgen test and nothing changed for the LegacySocket sockets, so at least I think this didn't break any of the existing code.

@stevenengler stevenengler merged commit 89442dc into shadow:main Jan 19, 2023
@stevenengler stevenengler deleted the wrap-tcp-rust branch January 19, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Milestone

Convert existing modules to Rust

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenengler @sporksmith