Improve strace string logging#2669
Merged
stevenengler merged 2 commits intoshadow:mainfrom Jan 18, 2023
Merged
Conversation
Codecov ReportBase: 67.73% // Head: 68.01% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2669 +/- ##
==========================================
+ Coverage 67.73% 68.01% +0.27%
==========================================
Files 202 202
Lines 30305 30304 -1
Branches 5917 5920 +3
==========================================
+ Hits 20527 20611 +84
+ Misses 5125 5025 -100
- Partials 4653 4668 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sporksmith
approved these changes
Jan 18, 2023
22de644 to
2d1afe9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small improvements to the syscall string logging in
fmt_stringto make it more readable, and more similar tofmt_buffer. Also added an optionallenargument since some syscalls that take string arguments can also have a length argument (for examplegetsockoptwithTCP_CONGESTION).I tried using the memory manager's string methods (
copy_str_from_ptr) but these don't return partial strings when a NUL isn't found so they can't be used here. I think the current method should be of similar performance (it iterates over aProcessMemoryRef), only it does an extraStringallocation. We could have a stack-allocatedu8array and cast it to a&strat the end, but I'm not sure it's worth it here.