Merged
Conversation
Codecov ReportBase: 67.80% // Head: 68.19% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2665 +/- ##
==========================================
+ Coverage 67.80% 68.19% +0.38%
==========================================
Files 202 202
Lines 30304 30315 +11
Branches 5920 5919 -1
==========================================
+ Hits 20549 20673 +124
+ Misses 5087 4964 -123
- Partials 4668 4678 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b6fb21c to
e8c7a4b
Compare
stevenengler
approved these changes
Jan 18, 2023
Since the C Process only contained a pointer to the RustProcess, we can now unify the two. For compatibility we currently give C a `* mut RustProcess` instead of a `* const RustProcess`. This is fragile, but sound as long as we never actually dereference to a `&mut RustProcess`.
This also forces us to add some explicit includes to other files, which were previously getting them transitively from process.h
e8c7a4b to
70e6d89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.