Skip to content

bind-shadow test: extend timeout#2663

Merged
sporksmith merged 2 commits intoshadow:mainfrom
sporksmith:bind-test-timeout
Jan 13, 2023
Merged

bind-shadow test: extend timeout#2663
sporksmith merged 2 commits intoshadow:mainfrom
sporksmith:bind-test-timeout

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

@sporksmith sporksmith commented Jan 13, 2023

This has been timing out occasionally in CI on debug builds. It doesn't seem to have gotten slower in release builds, and doesn't have any obvious culprits in perf.

@sporksmith sporksmith self-assigned this Jan 13, 2023
@sporksmith sporksmith enabled auto-merge January 13, 2023 20:09
@github-actions github-actions bot added Component: Build Build/install tools and dependencies Component: Testing Unit and integration tests and frameworks labels Jan 13, 2023
@stevenengler stevenengler mentioned this pull request Jan 13, 2023
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 13, 2023

Codecov Report

Base: 67.72% // Head: 68.13% // Increases project coverage by +0.40% 🎉

Coverage data is based on head (7120c02) compared to base (fc67710).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2663      +/-   ##
==========================================
+ Coverage   67.72%   68.13%   +0.40%     
==========================================
  Files         202      202              
  Lines       30289    30289              
  Branches     5906     5906              
==========================================
+ Hits        20513    20636     +123     
+ Misses       5122     4977     -145     
- Partials     4654     4676      +22
Flag Coverage Δ
tests 68.13% <ø> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/core/logger/shadow_logger.rs 69.61% <0.00%> (-2.77%) ⬇️
...c/main/utility/synchronization/count_down_latch.rs 85.10% <0.00%> (-0.54%) ⬇️
src/main/host/host.rs 80.64% <0.00%> (-0.18%) ⬇️
src/main/host/memory_manager/memory_mapper.rs 71.63% <0.00%> (+0.20%) ⬆️
src/main/host/descriptor/mod.rs 67.63% <0.00%> (+0.20%) ⬆️
src/main/host/syscall/handler/socket.rs 68.43% <0.00%> (+0.21%) ⬆️
src/main/host/process.rs 77.82% <0.00%> (+0.31%) ⬆️
src/main/host/descriptor/pipe.rs 85.00% <0.00%> (+0.62%) ⬆️
src/main/core/manager.rs 64.30% <0.00%> (+0.66%) ⬆️
src/main/core/sim_config.rs 55.45% <0.00%> (+0.87%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sporksmith sporksmith merged commit a2161b3 into shadow:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenengler stevenengler stevenengler approved these changes

Assignees

@sporksmith sporksmith

Labels

Component: Build Build/install tools and dependencies Component: Testing Unit and integration tests and frameworks

Projects

None yet

Milestone

Code health and maintenance

Development

Successfully merging this pull request may close these issues.

2 participants

@sporksmith @stevenengler