Remove unneeded workaround in syscallhandler_epoll_ctl#2660
Merged
stevenengler merged 3 commits intoshadow:mainfrom Jan 13, 2023
Merged
Remove unneeded workaround in syscallhandler_epoll_ctl#2660stevenengler merged 3 commits intoshadow:mainfrom
syscallhandler_epoll_ctl#2660stevenengler merged 3 commits intoshadow:mainfrom
Conversation
1b9a689 to
1c8226a
Compare
Codecov ReportBase: 68.13% // Head: 68.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2660 +/- ##
==========================================
+ Coverage 68.13% 68.26% +0.13%
==========================================
Files 202 202
Lines 30289 30289
Branches 5906 5906
==========================================
+ Hits 20636 20677 +41
+ Misses 4977 4936 -41
Partials 4676 4676
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
1c8226a to
f07d246
Compare
robgjansen
approved these changes
Jan 13, 2023
f07d246 to
12adcab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1101 (comment). Also adds a check for closed files in
epoll_control()since TCP sockets are no longer always treated asLegacyFiles (they are now sometimes wrapped as rust file objects).