Skip to content

Log socket addresses in the syscall logger#2652

Merged
stevenengler merged 3 commits intoshadow:mainfrom
stevenengler:extended-strace-logging
Jan 11, 2023
Merged

Log socket addresses in the syscall logger#2652
stevenengler merged 3 commits intoshadow:mainfrom
stevenengler:extended-strace-logging

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Jan 11, 2023 •
edited
Loading

Examples:

connect(-1, 127.0.0.1:11111, 16) = -9 (EBADF: Bad file number)
bind(3, 0.0.0.0:0, 16) = 0
connect(3, sockaddr_un { path: "/asdf/qwerty/y89pq234589oles.sock" }, 110) = -2 (ENOENT: No such file or directory)
bind(29, sockaddr_un { unnamed }, 2) = 0
connect(30, sockaddr_un { abstract: "7d68a" }, 8) = 0

@stevenengler stevenengler self-assigned this Jan 11, 2023
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Jan 11, 2023
@stevenengler stevenengler force-pushed the extended-strace-logging branch 2 times, most recently from 97ff45d to 7ea5324 Compare January 11, 2023 04:13
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 11, 2023 •
edited
Loading

Codecov Report

Base: 67.48% // Head: 68.21% // Increases project coverage by +0.72% 🎉

Coverage data is based on head (7ea5324) compared to base (ce35b63).
Patch coverage: 75.94% of modified lines in pull request are covered.

❗ Current head 7ea5324 differs from pull request most recent head 0a44ee2. Consider uploading reports for the commit 0a44ee2 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2652      +/-   ##
==========================================
+ Coverage   67.48%   68.21%   +0.72%     
==========================================
  Files         202      202              
  Lines       30056    30095      +39     
  Branches     5847     5853       +6     
==========================================
+ Hits        20284    20528     +244     
+ Misses       5167     4924     -243     
- Partials     4605     4643      +38
Flag Coverage Δ
tests 68.21% <75.94%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/syscall/handler/mod.rs 80.34% <67.56%> (+0.34%) ⬆️
src/main/host/syscall/type_formatting.rs 77.58% <70.00%> (+2.11%) ⬆️
src/main/host/syscall/handler/socket.rs 68.85% <75.00%> (+0.35%) ⬆️
src/main/utility/sockaddr.rs 73.53% <89.28%> (+1.93%) ⬆️
src/main/core/scheduler/pools/bounded.rs 74.50% <0.00%> (-4.71%) ⬇️
src/test/futex/test_futex.c 64.00% <0.00%> (-1.34%) ⬇️
src/main/host/descriptor/pipe.rs 84.37% <0.00%> (-0.63%) ⬇️
src/lib/tsc/tsc_test.c 12.67% <0.00%> (ø)
src/main/core/support/units.rs 56.62% <0.00%> (+0.25%) ⬆️
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stevenengler stevenengler force-pushed the extended-strace-logging branch from 7ea5324 to 0a44ee2 Compare January 11, 2023 15:38
@stevenengler stevenengler merged commit 1c49115 into shadow:main Jan 11, 2023
@stevenengler stevenengler deleted the extended-strace-logging branch January 11, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Milestone

Improve design of logging and output ...

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenengler @sporksmith