Skip to content

Process: move thread list to Rust#2650

Merged
sporksmith merged 3 commits intoshadow:mainfrom
sporksmith:process-threads
Jan 10, 2023
Merged

Process: move thread list to Rust#2650
sporksmith merged 3 commits intoshadow:mainfrom
sporksmith:process-threads

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

@sporksmith sporksmith commented Jan 9, 2023

No description provided.

@github-actions github-actions bot added Component: Libraries Support functions like LD_PRELOAD and logging Component: Main Composing the core Shadow executable labels Jan 9, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 9, 2023 •
edited
Loading

Codecov Report

Base: 68.04% // Head: 67.77% // Decreases project coverage by -0.26% ⚠️

Coverage data is based on head (eae41be) compared to base (eccbd02).
Patch coverage: 82.03% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2650      +/-   ##
==========================================
- Coverage   68.04%   67.77%   -0.27%     
==========================================
  Files         202      202              
  Lines       29948    30056     +108     
  Branches     5838     5847       +9     
==========================================
- Hits        20377    20370       -7     
- Misses       4930     5064     +134     
+ Partials     4641     4622      -19
Flag Coverage Δ
tests 67.77% <82.03%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/lib/shadow-shim-helper-rs/src/shim_shmem.rs 76.82% <ø> (ø)
src/main/host/process.rs 83.41% <81.11%> (-0.46%) ⬇️
src/main/host/thread.rs 78.57% <81.81%> (+6.91%) ⬆️
src/main/host/syscall_condition.rs 84.74% <100.00%> (+1.41%) ⬆️
src/main/host/syscall/handler/eventfd.rs 0.00% <0.00%> (-72.23%) ⬇️
src/main/host/descriptor/eventfd.rs 21.21% <0.00%> (-44.45%) ⬇️
src/main/host/syscall/handler/fcntl.rs 50.00% <0.00%> (-15.72%) ⬇️
src/main/host/descriptor/descriptor_table.rs 69.56% <0.00%> (-10.15%) ⬇️
src/main/host/syscall/handler/unistd.rs 66.00% <0.00%> (-7.12%) ⬇️
src/main/host/syscall/handler/mod.rs 82.50% <0.00%> (-3.75%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

stevenengler
stevenengler approved these changes Jan 10, 2023
View reviewed changes
@sporksmith sporksmith enabled auto-merge January 10, 2023 20:50
@sporksmith sporksmith merged commit ce35b63 into shadow:main Jan 10, 2023
@sporksmith sporksmith deleted the process-threads branch January 10, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenengler stevenengler stevenengler approved these changes

Assignees

@sporksmith sporksmith

Labels

Component: Libraries Support functions like LD_PRELOAD and logging Component: Main Composing the core Shadow executable

Projects

None yet

Milestone

Convert existing modules to Rust

Development

Successfully merging this pull request may close these issues.

2 participants

@sporksmith @stevenengler