Simplify strace logging in Process#2649
Merged
stevenengler merged 1 commit intoshadow:mainfrom Jan 9, 2023
Merged
Conversation
The `StraceFmtMode` type exists for compatibility with C code, so its use has been replaced with `Option<FmtOptions>` in the process, host, and manager code. The `strace_logging_options: Option<FmtOptions>` and `strace_file: Option<File>` fields have been merged into a single `strace_logging: Option<StraceLogging>` field.
Codecov ReportBase: 67.88% // Head: 67.91% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2649 +/- ##
==========================================
+ Coverage 67.88% 67.91% +0.02%
==========================================
Files 201 202 +1
Lines 29852 29920 +68
Branches 5820 5832 +12
==========================================
+ Hits 20266 20319 +53
- Misses 4970 4980 +10
- Partials 4616 4621 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sporksmith
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
StraceFmtModetype exists for compatibility with C code (it's better to represent the "off" state as anOption::None), so its use has been replaced withOption<FmtOptions>in the process, host, and manager code. Thestrace_logging_options: Option<FmtOptions>andstrace_file: Option<File>fields have been merged into a singlestrace_logging: Option<StraceLogging>field.