Allow higher-level host log levels#2645
Merged
stevenengler merged 1 commit intoshadow:mainfrom Jan 11, 2023
Merged
Conversation
Codecov ReportBase: 67.98% // Head: 68.10% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2645 +/- ##
==========================================
+ Coverage 67.98% 68.10% +0.12%
==========================================
Files 202 202
Lines 30095 30100 +5
Branches 5853 5855 +2
==========================================
+ Hits 20459 20500 +41
+ Misses 4999 4954 -45
- Partials 4637 4646 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sporksmith
approved these changes
Jan 9, 2023
Previously if a host had a log level higher than the simulation log level, the host log level wouldn't take effect. Now you can specify higher host log levels (for example "trace") even if you specify a lower simulation log level (for example "info").
6479a71 to
baf6e17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if a host had a log level higher than the simulation log level, the host log level wouldn't take effect. Now you can specify higher host log levels (for example "trace") even if you specify a lower simulation log level (for example "info").
Closes #2643.
This doesn't appear to have any effect on runtime.
https://github.com/shadow/benchmark-results/tree/master/tor/2023-01-06-T17-24-59