Skip to content

Check for specific socket association before wildcard#2640

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:reorder-socket-lookup
Jan 4, 2023
Merged

Check for specific socket association before wildcard#2640
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:reorder-socket-lookup

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

Closes #2608.

@stevenengler stevenengler self-assigned this Jan 3, 2023
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Jan 3, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 3, 2023

Codecov Report

Base: 67.86% // Head: 68.10% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (2175cd1) compared to base (9bde717).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2640      +/-   ##
==========================================
+ Coverage   67.86%   68.10%   +0.23%     
==========================================
  Files         201      201              
  Lines       29496    29496              
  Branches     5800     5800              
==========================================
+ Hits        20017    20087      +70     
+ Misses       4872     4790      -82     
- Partials     4607     4619      +12     
Flag Coverage Δ
tests 68.10% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/core/scheduler/pools/unbounded.rs 77.90% <0.00%> (-4.07%) ⬇️
src/main/core/logger/shadow_logger.rs 67.25% <0.00%> (-2.93%) ⬇️
src/main/host/memory_manager/memory_copier.rs 73.33% <0.00%> (-1.12%) ⬇️
src/main/host/syscall/handler/socket.rs 68.30% <0.00%> (-0.20%) ⬇️
src/main/host/memory_manager/memory_mapper.rs 71.84% <0.00%> (+0.20%) ⬆️
src/main/host/descriptor/mod.rs 67.43% <0.00%> (+0.20%) ⬆️
src/main/host/process.rs 85.35% <0.00%> (+0.27%) ⬆️
src/main/core/sim_config.rs 55.45% <0.00%> (+0.43%) ⬆️
src/main/core/manager.rs 63.83% <0.00%> (+0.44%) ⬆️
src/main/host/descriptor/pipe.rs 84.37% <0.00%> (+1.25%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stevenengler stevenengler force-pushed the reorder-socket-lookup branch from 7ce4df6 to 2175cd1 Compare January 3, 2023 23:56
@stevenengler stevenengler merged commit fc18b7f into shadow:main Jan 4, 2023
@stevenengler stevenengler deleted the reorder-socket-lookup branch January 4, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When receiving packets, the network interface looks for general associations before specific associations

2 participants