Skip to content

TGen speed test threshold#2633

Merged
robgjansen merged 2 commits intoshadow:mainfrom
robgjansen:tgen-thresh
Dec 22, 2022
Merged

TGen speed test threshold#2633
robgjansen merged 2 commits intoshadow:mainfrom
robgjansen:tgen-thresh

Conversation

@robgjansen
Copy link
Copy Markdown
Member

Lowers the threshold since @stevenengler found that running the tests slightly differently (e.g. changing the host id sort order) will require a lower threshold to pass all of the TGen tests. (I think the only one that requires a lower threshold is tgen-duration-1mbit_300ms-1000streams-shadow.)

@robgjansen robgjansen added Component: Testing Unit and integration tests and frameworks Component: Documentation In-repository documentation, under docs/ labels Dec 22, 2022
@robgjansen robgjansen self-assigned this Dec 22, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 22, 2022

Codecov Report

Base: 67.23% // Head: 67.76% // Increases project coverage by +0.52% 🎉

Coverage data is based on head (116a5be) compared to base (92c7439).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2633      +/-   ##
==========================================
+ Coverage   67.23%   67.76%   +0.52%     
==========================================
  Files         201      201              
  Lines       29496    29496              
  Branches     5790     5790              
==========================================
+ Hits        19833    19989     +156     
+ Misses       5093     4909     -184     
- Partials     4570     4598      +28     
Flag Coverage Δ
tests 67.76% <ø> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/core/scheduler/pools/bounded.rs 76.47% <0.00%> (-1.18%) ⬇️
src/main/core/manager.rs 63.16% <0.00%> (-0.23%) ⬇️
src/main/host/descriptor/mod.rs 67.22% <0.00%> (+0.41%) ⬆️
src/main/host/host.rs 81.25% <0.00%> (+0.55%) ⬆️
src/main/host/syscall/handler/socket.rs 68.89% <0.00%> (+0.59%) ⬆️
src/test/futex/test_futex.c 65.33% <0.00%> (+1.33%) ⬆️
src/main/host/memory_manager/mod.rs 76.45% <0.00%> (+1.61%) ⬆️
src/main/network/graph/mod.rs 58.19% <0.00%> (+1.67%) ⬆️
src/main/host/descriptor/pipe.rs 83.75% <0.00%> (+1.87%) ⬆️
src/main/core/sim_config.rs 55.02% <0.00%> (+2.18%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robgjansen robgjansen merged commit 1b89702 into shadow:main Dec 22, 2022
@robgjansen robgjansen deleted the tgen-thresh branch December 22, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Documentation In-repository documentation, under docs/ Component: Testing Unit and integration tests and frameworks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants