Fix an issue with the _test_implicit_bind test#2630
Merged
robgjansen merged 1 commit intoshadow:mainfrom Dec 22, 2022
Merged
Conversation
robgjansen
approved these changes
Dec 21, 2022
Codecov ReportBase: 68.14% // Head: 68.00% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2630 +/- ##
==========================================
- Coverage 68.14% 68.00% -0.15%
==========================================
Files 201 201
Lines 29490 29496 +6
Branches 5788 5790 +2
==========================================
- Hits 20097 20059 -38
- Misses 4787 4835 +48
+ Partials 4606 4602 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
9c0e43d to
ef089b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was calling connect twice but incorrectly comparing the first accepted socket with the second connect socket (which was already closed). This synchronizes the calls to connect(), accept(), and close() so that we correctly compare the ports of the related tuple of client, listener, and accepted sockets.