Skip to content

Use 0 as last refill time for new token buckets#2629

Merged
robgjansen merged 1 commit intoshadow:mainfrom
robgjansen:tok-new-time
Dec 22, 2022
Merged

Use 0 as last refill time for new token buckets#2629
robgjansen merged 1 commit intoshadow:mainfrom
robgjansen:tok-new-time

Conversation

@robgjansen
Copy link
Copy Markdown
Member

@robgjansen robgjansen commented Dec 21, 2022

This will allow us create token buckets during host creation, when we don't yet have a valid worker object from which we can get the time.

@robgjansen robgjansen added Type: Enhancement New functionality or improved design Component: Main Composing the core Shadow executable labels Dec 21, 2022
@robgjansen robgjansen self-assigned this Dec 21, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 22, 2022 •
edited
Loading

Codecov Report

Base: 67.58% // Head: 68.07% // Increases project coverage by +0.49% 🎉

Coverage data is based on head (7aa3481) compared to base (038fa65).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 7aa3481 differs from pull request most recent head 28f3542. Consider uploading reports for the commit 28f3542 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2629      +/-   ##
==========================================
+ Coverage   67.58%   68.07%   +0.49%     
==========================================
  Files         201      200       -1     
  Lines       29502    29523      +21     
  Branches     5789     5791       +2     
==========================================
+ Hits        19938    20098     +160     
+ Misses       4977     4814     -163     
- Partials     4587     4611      +24
Flag Coverage Δ
tests 68.07% <100.00%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/network/relay/token_bucket.rs 71.77% <100.00%> (ø)
src/test/futex/test_futex.c 64.00% <0.00%> (-1.34%) ⬇️
...c/main/utility/synchronization/count_down_latch.rs 85.10% <0.00%> (-0.54%) ⬇️
src/main/core/sim_config.rs 54.58% <0.00%> (-0.44%) ⬇️
src/lib/tsc/tsc_test.c 12.67% <0.00%> (ø)
src/main/host/syscall/mod.rs 100.00% <0.00%> (ø)
src/main/host/syscall/type_formatting.rs
src/main/host/syscall/formatter.rs
src/main/host/syscall/format.rs 79.63% <0.00%> (ø)
src/main/host/process.rs 85.35% <0.00%> (+0.27%) ⬆️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robgjansen robgjansen enabled auto-merge (squash) December 22, 2022 02:15
@robgjansen robgjansen merged commit 8a50fe6 into shadow:main Dec 22, 2022
@robgjansen robgjansen deleted the tok-new-time branch December 22, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@robgjansen robgjansen

Labels

Component: Main Composing the core Shadow executable Type: Enhancement New functionality or improved design

Projects

None yet

Milestone

Improve modularity of router object

Development

Successfully merging this pull request may close these issues.

2 participants

@robgjansen @sporksmith