Skip to content

Remove unused router code#2628

Merged
robgjansen merged 1 commit intoshadow:mainfrom
robgjansen:router-cleanup
Dec 22, 2022
Merged

Remove unused router code#2628
robgjansen merged 1 commit intoshadow:mainfrom
robgjansen:router-cleanup

Conversation

@robgjansen
Copy link
Copy Markdown
Member

@robgjansen robgjansen commented Dec 21, 2022

No description provided.

@robgjansen robgjansen added Type: Maintenance Refactoring, cleanup, documenation, or process improvements Component: Main Composing the core Shadow executable labels Dec 21, 2022
@robgjansen robgjansen self-assigned this Dec 21, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 22, 2022 •
edited
Loading

Codecov Report

Base: 67.58% // Head: 68.14% // Increases project coverage by +0.55% 🎉

Coverage data is based on head (f51e978) compared to base (038fa65).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2628      +/-   ##
==========================================
+ Coverage   67.58%   68.14%   +0.55%     
==========================================
  Files         201      201              
  Lines       29502    29490      -12     
  Branches     5789     5788       -1     
==========================================
+ Hits        19938    20095     +157     
+ Misses       4977     4785     -192     
- Partials     4587     4610      +23
Flag Coverage Δ
tests 68.14% <100.00%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/network/router/mod.rs 75.00% <ø> (+5.55%) ⬆️
src/main/core/worker.rs 82.55% <100.00%> (ø)
src/test/futex/test_futex.c 64.00% <0.00%> (-1.34%) ⬇️
src/main/host/memory_manager/memory_copier.rs 73.33% <0.00%> (-1.12%) ⬇️
...c/main/utility/synchronization/count_down_latch.rs 85.10% <0.00%> (-0.54%) ⬇️
src/main/core/sim_config.rs 54.58% <0.00%> (-0.44%) ⬇️
src/main/host/syscall/handler/socket.rs 68.50% <0.00%> (ø)
src/main/host/memory_manager/memory_mapper.rs 71.63% <0.00%> (+0.20%) ⬆️
src/main/host/descriptor/pipe.rs 84.37% <0.00%> (+0.62%) ⬆️
src/main/host/host.rs 81.43% <0.00%> (+0.73%) ⬆️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robgjansen robgjansen enabled auto-merge (squash) December 22, 2022 01:38
@robgjansen robgjansen merged commit 226db6e into shadow:main Dec 22, 2022
@robgjansen robgjansen deleted the router-cleanup branch December 22, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@robgjansen robgjansen

Labels

Component: Main Composing the core Shadow executable Type: Maintenance Refactoring, cleanup, documenation, or process improvements

Projects

None yet

Milestone

Improve modularity of router object

Development

Successfully merging this pull request may close these issues.

2 participants

@robgjansen @sporksmith