Skip to content

Changed two debug logs to trace#2627

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:remove-bind-debug-log
Dec 21, 2022
Merged

Changed two debug logs to trace#2627
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:remove-bind-debug-log

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Dec 21, 2022

This will hopefully fix an occasional timeout in the bind-shadow test. This changes the rust socket() and bind() syscalls to behave how the C versions do, which should significantly reduce the number of log lines in the bind-shadow test.

@stevenengler stevenengler self-assigned this Dec 21, 2022
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Dec 21, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 21, 2022

Codecov Report

Base: 68.34% // Head: 68.23% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (3567360) compared to base (1f71d77).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2627      +/-   ##
==========================================
- Coverage   68.34%   68.23%   -0.11%     
==========================================
  Files         200      200              
  Lines       29522    29522              
  Branches     5791     5791              
==========================================
- Hits        20176    20145      -31     
- Misses       4732     4760      +28     
- Partials     4614     4617       +3     
Flag Coverage Δ
tests 68.23% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/syscall/handler/socket.rs 69.09% <0.00%> (+0.78%) ⬆️
src/main/host/descriptor/descriptor_table.rs 71.01% <0.00%> (-8.70%) ⬇️
src/main/network/graph/mod.rs 58.19% <0.00%> (-4.69%) ⬇️
src/main/utility/shm_cleanup.rs 59.09% <0.00%> (-4.55%) ⬇️
src/main/core/sim_config.rs 54.14% <0.00%> (-3.06%) ⬇️
src/main/host/syscall/handler/ioctl.rs 57.14% <0.00%> (-2.86%) ⬇️
src/main/core/main.rs 40.50% <0.00%> (-2.54%) ⬇️
src/main/host/memory_manager/memory_copier.rs 73.33% <0.00%> (-2.23%) ⬇️
src/main/host/syscall/handler/fcntl.rs 64.28% <0.00%> (-1.43%) ⬇️
src/main/utility/sockaddr.rs 71.60% <0.00%> (-1.21%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stevenengler stevenengler merged commit f866ed7 into shadow:main Dec 21, 2022
@stevenengler stevenengler deleted the remove-bind-debug-log branch December 21, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants