Merged
Conversation
Codecov ReportBase: 67.45% // Head: 67.46% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2624 +/- ##
==========================================
+ Coverage 67.45% 67.46% +0.01%
==========================================
Files 200 201 +1
Lines 29523 29502 -21
Branches 5791 5789 -2
==========================================
- Hits 19914 19904 -10
+ Misses 5032 5020 -12
- Partials 4577 4578 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sporksmith
approved these changes
Dec 20, 2022
When supporting new types in the syscall logger, the `SyscallDataDisplay`, `SyscallPtrDisplay`, and `TryFromSyscallReg` traits should be implemented in `syscall::type_formatting`.
964d298 to
08e0850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original version used extra traits to make it simpler to support new types in the logger, but these extra traits have made the logging code much more complicated, and this complexity isn't worth it. This PR also moves some code around into different modules, and changes the
log_syscallmacro to generate code using the quote library rather than parsing it from a string, since Shadow already depends on quote.