Support bind() for tcp wrapper#2611
Merged
stevenengler merged 1 commit intoshadow:mainfrom Dec 20, 2022
Merged
Conversation
afe4852 to
314b6e0
Compare
Codecov ReportBase: 68.01% // Head: 68.16% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2611 +/- ##
==========================================
+ Coverage 68.01% 68.16% +0.15%
==========================================
Files 200 199 -1
Lines 29278 29250 -28
Branches 5755 5750 -5
==========================================
+ Hits 19912 19939 +27
+ Misses 4770 4728 -42
+ Partials 4596 4583 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sporksmith
approved these changes
Dec 15, 2022
6bd92fe to
bc79ec4
Compare
bc79ec4 to
ae76ae6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This passes the network namespace to the socket during the bind call, which isn't how Linux does it (in Linux, sockets hold a reference-counted reference to the network namespace in it's inode), but in Shadow we don't use reference counting on the network namespace and we don't support multiple network namespaces so we need to pass it here.