Move host networking to new NetworkNamespace object#2607
Merged
stevenengler merged 4 commits intoshadow:mainfrom Dec 14, 2022
Merged
Move host networking to new NetworkNamespace object#2607stevenengler merged 4 commits intoshadow:mainfrom
NetworkNamespace object#2607stevenengler merged 4 commits intoshadow:mainfrom
Conversation
c687d48 to
0acc73e
Compare
Codecov ReportBase: 67.37% // Head: 67.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2607 +/- ##
==========================================
+ Coverage 67.37% 67.48% +0.10%
==========================================
Files 198 199 +1
Lines 29180 29199 +19
Branches 5739 5735 -4
==========================================
+ Hits 19661 19705 +44
+ Misses 4968 4931 -37
- Partials 4551 4563 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sporksmith
approved these changes
Dec 14, 2022
0acc73e to
4d2fbc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This serves two main purposes:
Socket::bind()that needs to be able to associate the socket with a network interface, we can pass it just thisNetworkNamespaceobject instead of needing to pass the entireHost. This provides better encapsulation.