Add examples for dynamic shadow config generation#2605
Add examples for dynamic shadow config generation#2605sporksmith merged 3 commits intoshadow:mainfrom
Conversation
|
I could be convinced to drop the nix example. I think it's neat, and the language has a lot more useful features for this kind of thing, but it's admittedly weird to point to given how coupled it is with the nix package manager. |
Codecov ReportBase: 67.78% // Head: 67.63% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2605 +/- ##
==========================================
- Coverage 67.78% 67.63% -0.16%
==========================================
Files 198 198
Lines 29180 29192 +12
Branches 5739 5740 +1
==========================================
- Hits 19781 19743 -38
- Misses 4829 4885 +56
+ Partials 4570 4564 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Oh! Just noticed that https://shadow.github.io/docs/guide/shadow_config_overview.html#yaml-extensions-experimental already talks about the yaml extensions and has examples. I do kind of like having a separate page with single running example of the yaml extension + generating with other tools, though. Maybe it's fine to have both, or maybe it'd make sense to drop the examples from the overview page and have a forward reference to this page instead? |
stevenengler
left a comment
There was a problem hiding this comment.
I do kind of like having a separate page with single running example of the yaml extension + generating with other tools, though. Maybe it's fine to have both, or maybe it'd make sense to drop the examples from the overview page and have a forward reference to this page instead?
Either sounds good to me.
bda02c3 to
545237e
Compare
No description provided.