Add support for rust sockets in the network interface#2603
Merged
stevenengler merged 4 commits intoshadow:mainfrom Dec 12, 2022
Merged
Add support for rust sockets in the network interface#2603stevenengler merged 4 commits intoshadow:mainfrom
stevenengler merged 4 commits intoshadow:mainfrom
Conversation
The borrow was being held for longer than I had thought it was.
Codecov ReportBase: 67.26% // Head: 67.00% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
==========================================
- Coverage 67.26% 67.00% -0.27%
==========================================
Files 197 197
Lines 29115 29182 +67
Branches 5737 5740 +3
==========================================
- Hits 19584 19553 -31
- Misses 4985 5085 +100
+ Partials 4546 4544 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sporksmith
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the
InetSockettype inCompatSocket. We don't actually use this variant ofCompatSocketyet since the C bind/connect/listen syscall handlers work only withLegacySocketobjects. When we write these syscall handlers in rust, we can add ourInetSocketdirectly to the network interface instead of downcasting to aTcpSocketand then to aLegacySocketlike the C syscalls do.This does break the tracker's per-socket statistics, but we don't currently use them, we're considering removing them, and I will try to update the tracker in another PR.