Support ioctl() for tcp wrapper#2600
Merged
stevenengler merged 1 commit intoshadow:mainfrom Dec 9, 2022
Merged
Conversation
Codecov ReportBase: 67.83% // Head: 67.30% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2600 +/- ##
==========================================
- Coverage 67.83% 67.30% -0.53%
==========================================
Files 197 197
Lines 29097 29115 +18
Branches 5733 5737 +4
==========================================
- Hits 19737 19597 -140
- Misses 4793 4968 +175
+ Partials 4567 4550 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sporksmith
approved these changes
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forced generic type on
TypedPluginPtr::newwas useful here since originally I didn't specify it, and since functions liketcp_getInputBufferLengthreturn ani64and the plugin memory is ai32, it would have overwritten too many bytes without any kind of warning or error. But sinceTypedPluginPtr::newhas theNoTypeInferencerequirement, it failed to compile.