Skip to content

Support getsockname/getpeername() for tcp wrapper#2599

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:wrap-tcp-rust
Dec 9, 2022
Merged

Support getsockname/getpeername() for tcp wrapper#2599
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:wrap-tcp-rust

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Dec 9, 2022

No description provided.

@stevenengler stevenengler self-assigned this Dec 9, 2022
@github-actions github-actions bot added the Component: Main Composing the core Shadow executable label Dec 9, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2022 •
edited
Loading

Codecov Report

Base: 67.05% // Head: 67.07% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (16822c3) compared to base (41e0def).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2599      +/-   ##
==========================================
+ Coverage   67.05%   67.07%   +0.01%     
==========================================
  Files         197      197              
  Lines       29083    29097      +14     
  Branches     5733     5733              
==========================================
+ Hits        19502    19517      +15     
  Misses       5035     5035              
+ Partials     4546     4545       -1
Flag Coverage Δ
tests 67.07% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/syscall/handler/socket.rs 65.60% <ø> (+0.76%) ⬆️
src/main/host/descriptor/socket/inet/tcp.rs 76.41% <100.00%> (+12.77%) ⬆️
src/main/host/descriptor/pipe.rs 68.12% <0.00%> (-9.38%) ⬇️
src/main/host/syscall/handler/random.rs 47.61% <0.00%> (-4.77%) ⬇️
src/main/host/syscall/handler/fcntl.rs 42.42% <0.00%> (-4.55%) ⬇️
src/main/core/scheduler/pools/unbounded.rs 77.90% <0.00%> (-4.07%) ⬇️
src/main/utility/shm_cleanup.rs 59.09% <0.00%> (-2.28%) ⬇️
src/main/host/syscall/handler/unistd.rs 53.49% <0.00%> (-2.06%) ⬇️
src/main/host/descriptor/shared_buf.rs 77.87% <0.00%> (-0.89%) ⬇️
src/main/core/sim_config.rs 53.27% <0.00%> (-0.88%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

sporksmith
sporksmith approved these changes Dec 9, 2022
View reviewed changes
@stevenengler stevenengler merged commit dd7e25f into shadow:main Dec 9, 2022
@stevenengler stevenengler deleted the wrap-tcp-rust branch December 9, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Milestone

Convert existing modules to Rust

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenengler @sporksmith