Skip to content

Add SyscallHandler::legacy_syscall helper function#2588

Merged
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:simplify-c-syscall-fn
Dec 5, 2022
Merged

Add SyscallHandler::legacy_syscall helper function#2588
stevenengler merged 1 commit intoshadow:mainfrom
stevenengler:simplify-c-syscall-fn

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Dec 5, 2022

No description provided.

@stevenengler stevenengler added the Component: Main Composing the core Shadow executable label Dec 5, 2022
@stevenengler stevenengler self-assigned this Dec 5, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2022 •
edited
Loading

Codecov Report

Base: 67.61% // Head: 67.22% // Decreases project coverage by -0.39% ⚠️

Coverage data is based on head (77ae3d6) compared to base (ec9f408).
Patch coverage: 93.10% of modified lines in pull request are covered.

❗ Current head 77ae3d6 differs from pull request most recent head 904821a. Consider uploading reports for the commit 904821a to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2588      +/-   ##
==========================================
- Coverage   67.61%   67.22%   -0.40%     
==========================================
  Files         195      195              
  Lines       29060    29025      -35     
  Branches     5716     5716              
==========================================
- Hits        19649    19512     -137     
- Misses       4856     4982     +126     
+ Partials     4555     4531      -24
Flag Coverage Δ
tests 67.22% <93.10%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/syscall/handler/unistd.rs 56.76% <50.00%> (-8.90%) ⬇️
src/main/host/syscall/handler/fcntl.rs 48.48% <100.00%> (-1.52%) ⬇️
src/main/host/syscall/handler/file.rs 80.00% <100.00%> (-5.72%) ⬇️
src/main/host/syscall/handler/ioctl.rs 21.87% <100.00%> (-29.65%) ⬇️
src/main/host/syscall/handler/mman.rs 78.26% <100.00%> (-6.59%) ⬇️
src/main/host/syscall/handler/mod.rs 78.20% <100.00%> (-3.13%) ⬇️
src/main/host/syscall/handler/socket.rs 64.17% <100.00%> (-1.69%) ⬇️
src/main/host/syscall/handler/time.rs 29.26% <0.00%> (-29.27%) ⬇️
src/main/host/descriptor/eventfd.rs 0.00% <0.00%> (-21.22%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

robgjansen
robgjansen approved these changes Dec 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@robgjansen robgjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@stevenengler stevenengler force-pushed the simplify-c-syscall-fn branch from 77ae3d6 to 904821a Compare December 5, 2022 17:20
@stevenengler stevenengler merged commit 3a59dfc into shadow:main Dec 5, 2022
@stevenengler stevenengler deleted the simplify-c-syscall-fn branch December 5, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robgjansen robgjansen robgjansen approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Milestone

Code health and maintenance

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenengler @robgjansen