Merged
Conversation
This would only leak rust file objects, so probably wouldn't have affected many applications. It would leak memory each time `epoll_ctl` was called with a fd pointing to a rust file object (except in the case of `EPOLL_CTL_ADD`).
Codecov ReportBase: 67.02% // Head: 67.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
==========================================
+ Coverage 67.02% 67.61% +0.58%
==========================================
Files 195 195
Lines 29056 29060 +4
Branches 5716 5716
==========================================
+ Hits 19475 19649 +174
+ Misses 5052 4856 -196
- Partials 4529 4555 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
robgjansen
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would only leak rust file objects, so probably wouldn't have affected many applications. It would leak memory each time
epoll_ctlwas called with a fd pointing to a rust file object (except in the case ofEPOLL_CTL_ADD).As expected, no memory usage change in the benchmark tor sim: