Build shadow once for extra tests#2572
Conversation
Codecov ReportBase: 67.89% // Head: 67.08% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2572 +/- ##
==========================================
- Coverage 67.89% 67.08% -0.82%
==========================================
Files 195 194 -1
Lines 29026 28791 -235
Branches 5708 5638 -70
==========================================
- Hits 19708 19314 -394
- Misses 4767 5021 +254
+ Partials 4551 4456 -95
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
5b92b27 to
0a62afa
Compare
|
Was making a follow-up PR to consolidate some of the other workflows, and it turned out to be pretty straightforward. Went ahead and added those commits here so we don't need to change the required actions multiple times. |
|
Here's an example of the full workflow: https://github.com/shadow/shadow/actions/runs/3574968073 It'd be nice to reduce the shadow build time too, but at least after this change we're building it once instead of 5x.
|
Previously we were building shadow for each version of tor that we test, as well as to test examples and do bandwidth tests with tgen. These all use the same build configuration and container, so we can save some GH resources by putting these all in one workflow and building shadow once. This also updates shadow configs and docs to use PATH-based search to locate tgen and tor. It's not strictly necessary for this change, but helps to decouple the "build shadow" job a bit from the other jobs that use its output, and is something we're moving towards in general to support alternative install locations.
5de9851 to
c4552ca
Compare
Previously we were building shadow for each version of tor that we test, as well as to test examples and do bandwidth tests with tgen. These all use the same build configuration and container, so we can save some GH resources by putting these all in one workflow and building shadow once.
This also updates shadow configs and docs to use PATH-based search to locate tgen and tor. It's not strictly necessary for this change, but helps to decouple the "build tgen" job a bit from the other jobs that use its output, and is something we're moving towards in general to support alternative install locations.