SelfContainedMutex: move from shadow-shim-helper-rs to shadow_shmem#2567
Merged
sporksmith merged 1 commit intoshadow:mainfrom Dec 1, 2022
Merged
SelfContainedMutex: move from shadow-shim-helper-rs to shadow_shmem#2567sporksmith merged 1 commit intoshadow:mainfrom
sporksmith merged 1 commit intoshadow:mainfrom
Conversation
Codecov ReportBase: 67.05% // Head: 66.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2567 +/- ##
==========================================
- Coverage 67.05% 66.95% -0.11%
==========================================
Files 195 195
Lines 29025 29025
Branches 5708 5705 -3
==========================================
- Hits 19464 19434 -30
- Misses 5038 5067 +29
- Partials 4523 4524 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
stevenengler
approved these changes
Nov 28, 2022
cb3727b to
01be86c
Compare
shadow_shmem is a better home for "utility" things to work with shared memory that don't depend on the rest of Shadow. This also lets us avoid having to compile shadow-shim-helper-rs when testing SelfContainedMutex in the loom configuration, which saves some work and lets us avoid some loom-specific workarounds in unrelated code. Progress on shadow#2566
01be86c to
4383dad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shadow_shmem is a better home for "utility" things to work with shared memory that don't depend on the rest of Shadow.
This also lets us avoid having to compile shadow-shim-helper-rs when testing SelfContainedMutex in the loom configuration, which saves some work and lets us avoid some loom-specific workarounds in unrelated code.
Progress on #2566