Skip to content

Use tgen to test shadow network performance#2549

Merged
robgjansen merged 2 commits intoshadow:mainfrom
robgjansen:perf-tests
Nov 18, 2022
Merged

Use tgen to test shadow network performance#2549
robgjansen merged 2 commits intoshadow:mainfrom
robgjansen:perf-tests

Conversation

@robgjansen
Copy link
Copy Markdown
Member

@robgjansen robgjansen commented Nov 16, 2022 •
edited
Loading

Closes #810

@robgjansen robgjansen added the Component: Testing Unit and integration tests and frameworks label Nov 16, 2022
@robgjansen robgjansen self-assigned this Nov 16, 2022
@github-actions github-actions bot added the Component: Build Build/install tools and dependencies label Nov 16, 2022
@github-actions github-actions bot added the Component: Documentation In-repository documentation, under docs/ label Nov 16, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 16, 2022 •
edited
Loading

Codecov Report

Base: 67.52% // Head: 67.94% // Increases project coverage by +0.42% 🎉

Coverage data is based on head (d262271) compared to base (e04b750).
Patch has no changes to coverable lines.

❗ Current head d262271 differs from pull request most recent head 254f4a1. Consider uploading reports for the commit 254f4a1 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2549      +/-   ##
==========================================
+ Coverage   67.52%   67.94%   +0.42%     
==========================================
  Files         193      193              
  Lines       28644    28608      -36     
  Branches     5623     5609      -14     
==========================================
+ Hits        19343    19439      +96     
+ Misses       4837     4694     -143     
- Partials     4464     4475      +11
Flag Coverage Δ
tests 67.94% <ø> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/core/scheduler/pools/bounded.rs 74.50% <0.00%> (-1.97%) ⬇️
src/test/futex/test_futex.c 64.00% <0.00%> (-1.34%) ⬇️
src/main/core/sim_config.rs 54.78% <0.00%> (-0.87%) ⬇️
src/main/host/memory_manager/memory_mapper.rs 71.63% <0.00%> (-0.21%) ⬇️
src/main/core/worker.rs 76.32% <0.00%> (-0.06%) ⬇️
src/lib/tsc/tsc_test.c 12.67% <0.00%> (ø)
src/main/utility/interval_map.rs 80.10% <0.00%> (ø)
src/main/host/descriptor/mod.rs 66.88% <0.00%> (+0.43%) ⬆️
src/main/host/descriptor/pipe.rs 86.07% <0.00%> (+0.63%) ⬆️
src/main/core/manager.rs 65.13% <0.00%> (+0.87%) ⬆️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robgjansen robgjansen marked this pull request as ready for review November 16, 2022 23:02
stevenengler
stevenengler approved these changes Nov 17, 2022
View reviewed changes
@robgjansen robgjansen enabled auto-merge November 18, 2022 18:41
@robgjansen robgjansen merged commit 6d3aa3a into shadow:main Nov 18, 2022
@robgjansen robgjansen deleted the perf-tests branch November 18, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenengler stevenengler stevenengler approved these changes

Assignees

@robgjansen robgjansen

Labels

Component: Build Build/install tools and dependencies Component: Documentation In-repository documentation, under docs/ Component: Testing Unit and integration tests and frameworks

Projects

None yet

Milestone

Validate and improve TCP simulation a...

Development

Successfully merging this pull request may close these issues.

Add tests of Shadow's TCP simulation accuracy

2 participants

@robgjansen @stevenengler