Add signal handler to flush logger on SIGINT/SIGTERM#2474
Merged
stevenengler merged 2 commits intoshadow:mainfrom Oct 16, 2022
valdaarhun:add_signal_handler
Merged
Add signal handler to flush logger on SIGINT/SIGTERM#2474stevenengler merged 2 commits intoshadow:mainfrom valdaarhun:add_signal_handler
stevenengler merged 2 commits intoshadow:mainfrom
valdaarhun:add_signal_handler
Conversation
Codecov ReportBase: 42.46% // Head: 43.29% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2474 +/- ##
==========================================
+ Coverage 42.46% 43.29% +0.82%
==========================================
Files 180 180
Lines 26703 26710 +7
Branches 5375 5379 +4
==========================================
+ Hits 11340 11563 +223
+ Misses 12735 12482 -253
- Partials 2628 2665 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
|
Thanks, looks great! Can you add an info-level log message before the flush with "Received signal {signal}. Exiting..." or something like that? |
Contributor
Author
Hi. Sure, will do. |
stevenengler
approved these changes
Oct 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2188 .
Hi. I am quite new to rust and am trying to learn on the fly. Please do let me know if this PR can be improved.