Return a netmask in getifaddrs()#2456
Merged
stevenengler merged 2 commits intoshadow:mainfrom Oct 7, 2022
Merged
Conversation
a4a1e11 to
264c21e
Compare
Codecov ReportBase: 42.47% // Head: 42.46% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2456 +/- ##
==========================================
- Coverage 42.47% 42.46% -0.02%
==========================================
Files 178 178
Lines 26051 26072 +21
Branches 5266 5269 +3
==========================================
+ Hits 11066 11072 +6
- Misses 12443 12455 +12
- Partials 2542 2545 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sporksmith
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The man page for
getifaddrs()says this is allowed to be NULL, but some applications/libraries such as libuv assume that this is non-null, so we may as well return something here. It returns a netmask of /8 for localhost and /24 for the public IP.Fixes the segfault in #2451.