Improve design of rust global shared state#2373
Merged
stevenengler merged 2 commits intoshadow:mainfrom Aug 23, 2022
Merged
Conversation
341d341 to
d6893dc
Compare
sporksmith
approved these changes
Aug 23, 2022
This allows us to drop everything in the global state when the simulation is done.
Instead of requiring two atomic reads to access `WORKER_SHARED` (one for `Lazy::deref` and another for `AtomicRefCell::borrow` in `WorkerShared`), we only need one atomic read (one for `Lazy::deref` in `Worker`).
55a99e8 to
d16ed95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WORKER_SHARED) in anAtomicRefCellso that we can drop the state when the simulation endsWORKER) to reverse any performance impact caused by theAtomicRefCell