Move more global state to the worker module#2372
Merged
stevenengler merged 10 commits intoshadow:mainfrom Aug 25, 2022
Merged
Conversation
44e4937 to
6d9fd8d
Compare
This uses the simulation time to check if the sim is completed rather than a flag in the scheduler.
The manager runs later than the worker, and may have things it also wants to make global.
This makes `ThreadSafeEventQueue` more easily accessible from Rust.
c9c0815 to
9e45bc6
Compare
sporksmith
approved these changes
Aug 25, 2022
9e45bc6 to
c3639db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow us to remove the
WorkerPools pointers to theSchedulerand theConfigOptions, which brings us a step closer to being able to write the scheduler and work pool in rust. The manager is becoming a bit overloaded with stuff, but it'll be easier to reorganize things later once it's all in rust.