Emulate PR_SET_DUMPABLE and misc improvements#2370
Merged
sporksmith merged 6 commits intoshadow:mainfrom Aug 23, 2022
Merged
Conversation
Just use `process_readPtr` here; it lets us handle errors more gracefully, and the extra copy of a uint32 has negligible cost.
Just use `process_readPtr` here; it lets us handle errors more gracefully, and the extra copy of a uint32 has negligible cost.
Having explicit cases instead of falling through to the default gives more useful log messages, with the name of the syscall, instead of just the number.
* Pass most operations through natively, as before. * Return ENOSYS for some that would interfere with Shadow. * Return EINVAL for any that aren't explicitly handled.
f3c50de to
5fb6542
Compare
stevenengler
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primarily to fix #2368
Some other minor improvements: