Move the runahead data from Controller to WorkerShared#2367
Merged
stevenengler merged 3 commits intoshadow:mainfrom Aug 22, 2022
Merged
Move the runahead data from Controller to WorkerShared#2367stevenengler merged 3 commits intoshadow:mainfrom
Controller to WorkerShared#2367stevenengler merged 3 commits intoshadow:mainfrom
Conversation
Controller to WorkerSharedController to WorkerShared
sporksmith
approved these changes
Aug 22, 2022
This is essentially a formatting change.
The `worker_updateMinHostRunahead` function has also been renamed to `worker_updateLowestUsedLatency`. This allows us to remove the `Controller` pointer from `WorkerPool`.
1894f61 to
5258819
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last part of the controller that is accessed globally, and lets us remove the controller pointer from the global worker pool.