Fix UB in the controller, and move the plugin error count to the worker module#2363
Merged
stevenengler merged 8 commits intoshadow:mainfrom Aug 19, 2022
Merged
Conversation
sporksmith
approved these changes
Aug 19, 2022
This allows us to update the status from several places without needing to share the entire status logger.
The status logger itself is already globally accessible through the controller, which is actually UB because the `StatusLogger` is not `Sync`. By making the status logger's state global, we can later make the status logger itself non-global.
This fixes the UB where `StatusLogger` is shared between threads but is not `Sync`.
It may sometimes take many real seconds to simulate one shadow second, so by showing milliseconds in the simulation time we can see that the simulation time is still advancing.
8ba4bb0 to
9a0ae04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status logger is globally accessible through the controller, which is UB because the
StatusLoggeris notSync. This PR makes the status logger's state global so that we can make the status logger itself non-global.Also moves the plugin error count to
worker::WORKER_SHAREDto be more explicit that this is intended to be used as a global.