Remove O_NOFOLLOW flag when mmap file in plugin#2353
Merged
sporksmith merged 5 commits intoshadow:mainfrom Aug 12, 2022
Merged
Conversation
sporksmith
requested changes
Aug 11, 2022
Contributor
sporksmith
left a comment
There was a problem hiding this comment.
Nice! We should add a regression test here, though.
LMK if you need more guidance, or if you'd rather not take that part on
Contributor
Author
|
@sporksmith Please check. |
sporksmith
approved these changes
Aug 12, 2022
Contributor
sporksmith
left a comment
There was a problem hiding this comment.
Thanks, looks good! Will merge shortly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the plugin mmaps a file opened with
O_NOFOLLOW, shadow cannot open the file for plugin and return error for mmap.example.c:
Running the above code will produce shadow log:
The error 40 (
ELOOP) is caused by theO_NOFOLLOWflag, which prevents the plugin opening the path where the base name is a symbolic link. So resetO_NOFOLLOWsince plugin is opening a symbolic link file in procfs. This flag is also unnecessary at this stage since it was already enforced when shadow opening the file.