Add tasks to the host instead of the worker#2343
Merged
stevenengler merged 1 commit intoshadow:mainfrom Aug 8, 2022
Merged
Conversation
New tasks should be added to the host rather than the worker. Currently the host simply passes the tasks on to the worker, but in the future the host may want to handle these tasks internally without involving the global worker.
sporksmith
approved these changes
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New tasks should be added to the host rather than the worker. In this PR the host simply passes the tasks on to the worker, but in the future the host may want to handle these tasks internally without involving the global worker. The current plan is to move the event queue into the host itself.