cmake: improve dependency processing#2331
Merged
sporksmith merged 3 commits intoshadow:mainfrom Aug 8, 2022
Merged
Conversation
stevenengler
approved these changes
Aug 8, 2022
stevenengler
approved these changes
Aug 8, 2022
This is more portable than the custom FindGLIB that was previously used. In particular it can correctly locate GLIB in a pure guix (and presumably nix, but untested) environment. Progress on shadow#2304
This allows extending the pkg-config search path, and supersedes --library and --include. fixup! squash! Make Rust target compiler flag generation more robust
* Used the IMPORTED_TARGET feature in pkg_check_modules to get a cmake target for glib, which can be queried for more metadata. * Made the dependency-processing loop check target type to determine how to handle correctly, and recurse into additional dependencies. * Removed some previous hard-coded workarounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #2304