Merged
Conversation
stevenengler
approved these changes
Aug 8, 2022
5824cb4 to
9c9d8b7
Compare
We only have one Thread "subclass" now, so we no longer need a vtable. Just call the threadpreload methods directly.
We already stopped supporting preload-mode without seccomp, and now we no longer support ptrace-mode. We were essentially using this to check whether we were in preload mode or ptrace mode; we no longer need it, nor the associated ptrace-mode fallbacks.
9c9d8b7 to
830e96b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work towards simplifying Thread, in preparation to port it to Rust.
There's a bit of strangeness now in how Thread and ManagedThread handle the syscall state. My tentative plan is to change ManagedThread's methods to not invoke the syscallhandler, and instead return to Thread when they get to a syscall, so that the syscall handling code can be consolidated there. For that to work well though, it's helpful to refactor SysCallResult to be a more proper tagged union. I have that ready, but it's a large refactor - better to split it into a follow-up PR.