Rename LegacyDescriptor to LegacyFile#2284
Merged
stevenengler merged 2 commits intoshadow:mainfrom Jul 15, 2022
Merged
Conversation
LegacyDescriptor to LegacyFileLegacyDescriptor to LegacyFile
This also involved renaming related functions (for example `legacydesc_` to `legacyfile_`), renaming related types (for example `DescriptorFunctionTable` to `LegacyFileFunctionTable`), renaming some union accessors (for example `as_descriptor` to `as_legacy_file`), and updating some comments.
d1fe1fe to
e8418ef
Compare
sporksmith
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the
Descriptoris now separate from theLegacyDescriptor, theLegacyDescriptornow acts as a posix file description (a Linuxstruct file) rather than a file descriptor. This renames theLegacyDescriptortoLegacyFileto make it more logically consistent, and to make it more consistent with the RustFileandOpenFiletypes.This also involved renaming related functions (for example
legacydesc_tolegacyfile_), renaming related types (for exampleDescriptorFunctionTabletoLegacyFileFunctionTable), renaming some union accessors (for exampleas_descriptortoas_legacy_file), and updating some comments.There are still variable names that reference "descriptors", but I will leave that for now.