shadow version string: get commit hash and dirty status more robustly#2281
Merged
sporksmith merged 1 commit intoshadow:mainfrom Jul 15, 2022
Merged
shadow version string: get commit hash and dirty status more robustly#2281sporksmith merged 1 commit intoshadow:mainfrom
sporksmith merged 1 commit intoshadow:mainfrom
Conversation
Adding the `--always` tag allows `git describe` to succeed even if a relevant tag can't be found. e.g. in the case of a shallow checkout without tags it results in a version string like "5a6993e" instead of the hard-coded version number "v2.1.0", which is misleading.
stevenengler
approved these changes
Jul 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the
--alwaystag allowsgit describeto succeed even ifa relevant tag can't be found. e.g. in the case of a shallow checkout
without tags it results in a version string like "5a6993e" instead of
the hard-coded version number "v2.1.0", which is misleading.