Skip to content

Add support for smaller vdso trampolines#2275

Merged
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:smaller-trampolines
Jul 14, 2022
Merged

Add support for smaller vdso trampolines#2275
sporksmith merged 1 commit intoshadow:mainfrom
sporksmith:smaller-trampolines

Conversation

@sporksmith
Copy link
Copy Markdown
Contributor

@sporksmith sporksmith commented Jul 13, 2022

Add support for smaller VDSO trampolines (13 bytes -> 5 bytes). This fixes panics in Ubuntu 22.04, whose vdso functions are already just 5-byte trampolines into internal functions (#2273)

Also adds some tests with an Ubuntu 22.04 kernel to the CI.

@github-actions github-actions bot added Component: Libraries Support functions like LD_PRELOAD and logging Component: Testing Unit and integration tests and frameworks labels Jul 13, 2022
@sporksmith sporksmith force-pushed the smaller-trampolines branch 2 times, most recently from d153b22 to 88a27da Compare July 13, 2022 17:31
@sporksmith sporksmith changed the title Smaller trampolines Add support for smaller vdso trampolines Jul 13, 2022
@sporksmith sporksmith linked an issue Jul 13, 2022 that may be closed by this pull request
@sporksmith sporksmith force-pushed the smaller-trampolines branch 2 times, most recently from de274cf to adbb5cf Compare July 13, 2022 17:50
@sporksmith sporksmith requested a review from stevenengler July 13, 2022 18:15
@sporksmith sporksmith marked this pull request as ready for review July 13, 2022 18:17
@sporksmith
Copy link
Copy Markdown
Contributor Author

@robgjansen could you update the required test statuses?

@sporksmith
Copy link
Copy Markdown
Contributor Author

@robgjansen could you update the required test statuses?

Nevermind for now - I'll split the CI changes into another PR

@sporksmith sporksmith force-pushed the smaller-trampolines branch from adbb5cf to c739196 Compare July 14, 2022 14:57
@github-actions github-actions bot removed the Component: Testing Unit and integration tests and frameworks label Jul 14, 2022
@sporksmith sporksmith enabled auto-merge (squash) July 14, 2022 14:57
@sporksmith sporksmith force-pushed the smaller-trampolines branch from 85455c0 to 177c225 Compare July 14, 2022 23:02
@sporksmith sporksmith merged commit 884cccc into shadow:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Libraries Support functions like LD_PRELOAD and logging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Size of __vdso_gettimeofday is too small for trampoline

2 participants