Skip to content

More organization changs to the manager / worker pool#2262

Merged
stevenengler merged 3 commits intoshadow:mainfrom
stevenengler:manager-reorg
Jul 7, 2022
Merged

More organization changs to the manager / worker pool#2262
stevenengler merged 3 commits intoshadow:mainfrom
stevenengler:manager-reorg

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

These changes are to prepare for the rust migration of the Manager.

  • Workers now add their local counters to the global counters --- Rather than having each worker add its counters to the manager through the global worker pool, each worker now adds its counters to the global counters and the manager then later reads from the global counters.
  • Worker pool now accesses the controller, pid watcher, and config directly --- This is work towards making the controller/manager/scheduler/workerpool more composable and to limit parent references.

@stevenengler stevenengler added Type: Maintenance Refactoring, cleanup, documenation, or process improvements Component: Main Composing the core Shadow executable labels Jul 7, 2022
@stevenengler stevenengler requested a review from sporksmith July 7, 2022 19:20
@stevenengler stevenengler self-assigned this Jul 7, 2022
Rather than having each worker add its counters to the manager through the
global worker pool, each worker now adds its counters to the global counters
and the manager then later reads from the global counters.
…ctly

This is work towards making the controller/manager/scheduler/workerpool more
composable and to limit parent references.
@stevenengler stevenengler enabled auto-merge July 7, 2022 20:35
@stevenengler stevenengler merged commit 9f931b4 into shadow:main Jul 7, 2022
@stevenengler stevenengler deleted the manager-reorg branch July 7, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Main Composing the core Shadow executable Type: Maintenance Refactoring, cleanup, documenation, or process improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants