Re-enable fcntl locking for regular files#2259
Merged
sporksmith merged 1 commit intoshadow:mainfrom Jul 7, 2022
Merged
Conversation
12a89f9 to
d7e3c22
Compare
stevenengler
approved these changes
Jul 7, 2022
Contributor
|
Nice catch! Was there a specific error message or wrong behaviour that caused you to notice this? |
This unbreaks arti's usage of sqlite. Unfortunately this implementation is incorrect if multiple processes actually access the same file's locks. See shadow#2258
Contributor
Author
arti propagated up an error about sqlite being unable to initialize. I think I found the fcntl returning EINVAL from the strace log. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unbreaks arti's usage of sqlite. Unfortunately this implementation
is incorrect if multiple processes actually access the same file's
locks. See #2258