Skip to content

Changes to controller, manager, and scheduler#2255

Merged
stevenengler merged 5 commits intoshadow:mainfrom
stevenengler:manager-reorg
Jul 5, 2022
Merged

Changes to controller, manager, and scheduler#2255
stevenengler merged 5 commits intoshadow:mainfrom
stevenengler:manager-reorg

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Jul 5, 2022 •
edited
Loading

Main changes:

  • removed unnecessary complexity from the manager and scheduler
  • removed manager field from the scheduler
  • moved the status bar and plugin error count to the controller (the intended design is that the simulation may have multiple managers and a single controller, so the controller seems like a better place for these)

@stevenengler stevenengler added the Component: Main Composing the core Shadow executable label Jul 5, 2022
@stevenengler stevenengler requested a review from sporksmith July 5, 2022 16:47
@stevenengler stevenengler self-assigned this Jul 5, 2022
@stevenengler stevenengler enabled auto-merge July 5, 2022 19:49
@stevenengler stevenengler merged commit f56b280 into shadow:main Jul 5, 2022
@stevenengler stevenengler deleted the manager-reorg branch July 5, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Milestone

Convert existing modules to Rust

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenengler @sporksmith