Restructure descriptors to support dup() for all descriptor/file types#2242
Merged
stevenengler merged 5 commits intoshadow:mainfrom Jun 28, 2022
Merged
Conversation
46d2a64 to
944152b
Compare
The `Descriptor` type now replaces the `CompatDescriptor`. The compatibility enum to support C `LegacyDescriptors` is a new `CompatFile` type. This restructuring now means that we support `dup()` and related syscalls for all descriptor/file types, including for `LegacyDescriptors`.
944152b to
1585a34
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1648.
The
Descriptortype now replaces theCompatDescriptor. The compatibility enum to support CLegacyDescriptorsis a newCompatFiletype contained within theDescriptor. This restructuring now means that we supportdup()and related syscalls for all file descriptors, including forLegacyDescriptors.