Renamed descriptor_ functions to legacydesc_#2241
Merged
stevenengler merged 1 commit intoshadow:mainfrom Jun 27, 2022
Merged
Conversation
This better matches the type name `LegacyDescriptor`. The prefix was chosen since `legacydesc_` has the same length as `descriptor_`, and also has the same length as `legacyfile_` if we choose to rename this again in the future.
sporksmith
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This better matches the type name
LegacyDescriptor. The prefix was chosen sincelegacydesc_has the same length asdescriptor_, and also has the same length aslegacyfile_if we choose to rename this again in the future.