Remove handle field from LegacyDescriptor#2240
Merged
stevenengler merged 11 commits intoshadow:mainfrom Jun 27, 2022
Merged
Conversation
sporksmith
approved these changes
Jun 27, 2022
3a9f317 to
84f365c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LegacyDescriptorstruct combines the file descriptor and file description into a single object by combining the fd handle and CLOEXEC flag with the underlying file object. This forces them to have a 1:1 relationship, where they should have a n:1 relationship for n>=0 (any number of file descriptors for a file description).This PR is a step towards removing this 1:1 relationship and towards supporting #1648. A follow-up PR will allow multiple fds for a
LegacyDescriptor.