Prepare manager for rust conversion#2230
Merged
stevenengler merged 11 commits intoshadow:mainfrom Jun 21, 2022
Merged
Conversation
4ed7e60 to
f8015ff
Compare
sporksmith
approved these changes
Jun 21, 2022
This doesn't seem to happen in practice, so panics when a debug build. Previously this used the global manager's syscall counts when there was no worker, but we don't need this complexity, and if we actually do try to add syscall counts when there's no worker, then it's probably an error anyway.
Shadow previously used the global manager's counters. This change was made so that the entire manager does not need to be global.
f8015ff to
8aaf2ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains some of the changes needed before we can move the manager to rust. It simplifies some of the manager code, and removes the
globalmanager(the global manager's syscall counter was removed, and the alloc/dealloc counters were moved to the worker module).