Replace 'Controller' with a rust version#2226
Merged
stevenengler merged 7 commits intoshadow:mainfrom Jun 21, 2022
Merged
Conversation
bd2bb73 to
85f7b56
Compare
ffc011b to
26c94d6
Compare
sporksmith
approved these changes
Jun 21, 2022
26c94d6 to
67badb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR doesn't change the simulation results in the benchmark:
The "Change random/seed/ordering behaviour to match older Shadow" commit is needed to obtain similar results/performance, otherwise the simulation performance is noticeably different without this commit: