Skip to content

Simplified the logging init, and other small code simplifications #2225

Merged
stevenengler merged 7 commits intoshadow:mainfrom
stevenengler:misc-changes
Jun 13, 2022
Merged

Simplified the logging init, and other small code simplifications #2225
stevenengler merged 7 commits intoshadow:mainfrom
stevenengler:misc-changes

Conversation

@stevenengler
Copy link
Copy Markdown
Contributor

@stevenengler stevenengler commented Jun 10, 2022

  • simplified logging initialization
  • moved log buffering decision from controller to main fn
  • moved tilde expansion unit test to the utility module
  • use the plugin path rather than argv[0] for execvpe()
  • removed unused 'runTimer' field from controller

The following changes are in preparation for moving the controller to rust.

  • set the host CPU frequency in the manager
  • manager reads the bootstrap end time directly from config

@stevenengler stevenengler added the Component: Main Composing the core Shadow executable label Jun 10, 2022
@stevenengler stevenengler requested a review from sporksmith June 10, 2022 15:00
@stevenengler stevenengler self-assigned this Jun 10, 2022
@stevenengler stevenengler enabled auto-merge June 13, 2022 15:16
@stevenengler stevenengler merged commit b479750 into shadow:main Jun 13, 2022
@stevenengler stevenengler deleted the misc-changes branch June 13, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sporksmith sporksmith sporksmith approved these changes

Assignees

@stevenengler stevenengler

Labels

Component: Main Composing the core Shadow executable

Projects

None yet

Milestone

Code health and maintenance

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenengler @sporksmith